refactor(aggregation): Make NashMTL and CAGrad always importable#679
Open
ValerianRey wants to merge 2 commits into
Open
refactor(aggregation): Make NashMTL and CAGrad always importable#679ValerianRey wants to merge 2 commits into
ValerianRey wants to merge 2 commits into
Conversation
Add _WithOptionalDeps mixin that raises ImportError at instantiation time when optional dependencies are missing, replacing the module-level guard that previously prevented import altogether. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ValerianRey
added
package: aggregation
cc: refactor
Contributor
Author
|
@PierreQuinton IMO this is ready. You can merge if it helps for the rest. |
Contributor
PierreQuinton
left a comment
PierreQuinton
left a comment
There was a problem hiding this comment.
LGTM. In the context of QP solvers and of #678 do you think we should make the aggregator or the projector a _WithOptionalDeps? I think that this would change where the mixin would go to.
Comment on lines
+26
to
+27
| missing = [name for name in self._REQUIRED_DEPS if find_spec(name) is None] | ||
| if missing: |
Contributor
There was a problem hiding this comment.
Clearer:
Suggested change
| missing = [name for name in self._REQUIRED_DEPS if find_spec(name) is None] | |
| if missing: | |
| missing = [name for name in self._REQUIRED_DEPS if find_spec(name) is None] | |
| if len(missing) != 0: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_WithOptionalDepsmixin to_mixins.py: subclasses declare_REQUIRED_DEPSand_INSTALL_HINT;__init__raisesImportErrorwith a clear install message if any dep is missingCAGradWeightingand_NashMTLWeightingnow inherit_WithOptionalDepsfirst, so the check fires at instantiation rather than at import timeCAGrad,CAGradWeighting, andNashMTLare now unconditionally importable and listed in__all__pytest.importorskip(the standard pattern) instead of a manualtry/except ImportErrorguard🤖 Generated with Claude Code